-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespaces template for creating new repo's. #1957
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1957 +/- ##
=======================================
Coverage 62.50% 62.50%
=======================================
Files 43 43
Lines 4902 4902
=======================================
Hits 3064 3064
Misses 1838 1838 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Excited to be able to play with this 😀
Any chance we could also add something similar to the top-level of the repo to also have it available to work on nf-core/tools? (in addition to pipelines)
I did more digging around and there should be some way to combine these: https://github.com/gitpod-io/template-gitpod-sxs-codespaces. The Codespaces environment is using the Gitpod image here. The Gitpod base image does have a lot of things we generally don't need, but it was used for docker and java included ( full list is https://github.com/gitpod-io/workspace-images/blob/HEAD/dazzle.yaml#L3. I was wondering initially if the Gitpod image could use the devcontainers image as a base, but I can't find what's included in them. Also what's the difference between Codespaces and Gitpod ? |
@mahesh-panchal and @ewels got the gitpod to work with codespaces to use the same base image. Give it a test. |
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Much leaner 🚀
@mahesh-panchal - what do you think about moving the GitPod files into .devcontainer
so that everything is together? It shouldn't matter where those files are, right?
The |
I think we could do a symbolic link if you want them in the same place. But that would the best solution to deal with harcoded locations these programs are looking for information. |
I think just keep the files where they are. Symlinking for the sake of grouping creates another file, and potential confusion when looking to update those files. |
Ok, sounds good! Just my final outstanding 3 comments @vsmalladi then can merge 👍🏻 |
@ewels awesome fixed outstanding issues. Should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests don't seem related to the files here so I'm going to approve it.
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was only minor tweaks left, so I fixed up myself. LGTM! Thanks! 🚀
PR checklist
Add codespaces template for when creating a new repository. Closes #1953
CHANGELOG.md
is updated